Skip to content

add CMake build system support #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

add CMake build system support #240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e0291e7
add CMake build system support
Nov 26, 2024
651427e
add static link support
Nov 26, 2024
6bbd177
add CMake build support to PythonQtGenerator
Nov 27, 2024
5ac1eca
prefer to use ${CMAKE_CURRENT_LIST_DIR}/generated_cpp
Nov 28, 2024
d1c8d34
add custom targets to automatically run generated commands
Dec 5, 2024
815730f
Initial support for using auto-generated wrappers
Feb 11, 2025
56bd7e4
enable testing
Feb 11, 2025
e02479f
add cmake ci
Feb 12, 2025
bd2ef21
CMake CI Process Validation
Feb 12, 2025
b1f079c
CMake CI Process Validation
Feb 12, 2025
85aa600
CMake CI Process Validation
Feb 12, 2025
d4f5f7f
CMake CI Process Validation
Feb 12, 2025
a02dd49
CMake CI Process Validation
Feb 12, 2025
09ea478
CMake CI Process Validation
Feb 12, 2025
e469f27
CMake CI Process Validation
Feb 13, 2025
952b6d3
Update cmake.yml
feihong-gz Feb 13, 2025
f474b3f
Update cmake.yml
feihong-gz Feb 13, 2025
473efa0
adapting more Qt header file include paths
Feb 13, 2025
22e38fc
fix _qt_include_prefix
Feb 13, 2025
cb96f7f
update cmake.yml
Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
cmake_minimum_required(VERSION 3.27)

project(PythonQt LANGUAGES CXX VERSION 3.5.6)

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Core)
find_package(Python3 COMPONENTS Development)

set(PYTHONQT_SUFFIX Qt${QT_VERSION_MAJOR}.${QT_VERSION_MINOR}-Python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR})


if(${QT_VERSION_MAJOR} VERSION_EQUAL 5)
if(${QT_VERSION_MINOR} VERSION_LESS 3)
set(PYTHONQT_GENERATED_PATH ${CMAKE_CURRENT_LIST_DIR}/generated_cpp_50)
elseif(${QT_VERSION_MINOR} VERSION_LESS 6)
set(PYTHONQT_GENERATED_PATH ${CMAKE_CURRENT_LIST_DIR}/generated_cpp_54)
elseif(${QT_VERSION_MINOR} VERSION_LESS 11)
set(PYTHONQT_GENERATED_PATH ${CMAKE_CURRENT_LIST_DIR}/generated_cpp_56)
elseif(${QT_VERSION_MINOR} VERSION_LESS 15)
set(PYTHONQT_GENERATED_PATH ${CMAKE_CURRENT_LIST_DIR}/generated_cpp_511)
else()
set(PYTHONQT_GENERATED_PATH ${CMAKE_CURRENT_LIST_DIR}/generated_cpp_515)
endif()
# elseif(${QT_VERSION_MAJOR} VERSION_EQUAL 6)
else()
message(FATAL "No generated sources exist for Qt${QT_VERSION}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not handle the (actually preferred) case of self-generated wrappers in generated_cpp, as done in the qmake file. Especially this will not work for Qt6, unless I'm missing something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to build generator using CMake, and so far it's testing well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

mkdir build
cmake -S  src -B build --install-prefix <path-to-install>
cmake --build build --parallel --target all install

Currently compiles and installs properly. Earlier I was thinking about how to use the code generated by generator, because in the configuration phase generator is not generated yet, and in the compilation phase it's too late. So I didn't do much about this later. But I currently have some ideas on how to solve this problem.
I apologize for not replying to you until now, as I don't usually follow github. It's going to be Chinese New Year now, so I probably won't do anything until after Chinese New Year.
My English is not very good either, so I hope you can understand what I said.
Meanwhile, wish you happy Chinese New Year in advance.

Translated with DeepL.com (free version)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, take your time, and thank you for your contribution!

Happy New Year to you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On CMake, I had to know the exact filename of the file to be generated, so I modified the file size limit. Also, this commit only executes properly on Qt5, Qt6 seems to generate some duplicates inside the source file. Maybe the generator needs some changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the current implementation may not be elegant, but it is a viable solution, subject to subsequent improvements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usiems is currently working on changing the preprocessor, this might resolve some issues, though I'm not sure.
If the solution is working, we can always improve it later, and if we have the CI tests in place (see my previous comment), this should be easier.

endif()

add_subdirectory(src)
# add_subdirectory(generator)
add_subdirectory(extensions)
add_subdirectory(tests)
# add_subdirectory(examples)
1 change: 1 addition & 0 deletions extensions/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add_subdirectory(PythonQt_QtAll)
103 changes: 103 additions & 0 deletions extensions/PythonQt_QtAll/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
project(QtAll LANGUAGES CXX)

set(CMAKE_AUTOMOC ON)

file(GLOB SOURCES *.h *.cpp)

if(BUILD_SHARED_LIBS)
add_library(${PROJECT_NAME} SHARED)
else()
add_library(${PROJECT_NAME} STATIC)
endif()

target_sources(${PROJECT_NAME} PRIVATE
${SOURCES}
${GENERATE_SOURCES}
)

target_link_libraries(${PROJECT_NAME} PUBLIC
Core
)

target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_LIST_DIR})

target_compile_definitions(${PROJECT_NAME} PRIVATE PYTHONQT_QTALL_EXPORTS)

list(APPEND QTMODULES Core Gui Svg Sql Network OpenGL Xml XmlPatterns Multimedia Qml Quick UiTools WebEngineWidgets WebKit)

find_package(Qt${QT_VERSION_MAJOR} COMPONENTS ${QTMODULES})

foreach(QTMODULE IN LISTS QTMODULES)
if(NOT TARGET Qt${QT_VERSION_MAJOR}::${QTMODULE})
continue()
endif()

string(TOLOWER ${QTMODULE} qtmodule)
file(GLOB GENERATE_SOURCES
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_${qtmodule}/*.h
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_${qtmodule}/*.cpp
)
target_sources(${PROJECT_NAME} PRIVATE ${GENERATE_SOURCES})
target_link_libraries(${PROJECT_NAME} PUBLIC Qt${QT_VERSION_MAJOR}::${QTMODULE})

string(TOUPPER ${QTMODULE} qtmodule)
target_compile_definitions(${PROJECT_NAME} PRIVATE PYTHONQT_WITH_${qtmodule})
endforeach()

if(TARGET Qt${QT_VERSION_MAJOR}::Gui)
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Widgets PrintSupport REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::Widgets
Qt${QT_VERSION_MAJOR}::PrintSupport
)
endif()

if(TARGET Qt${QT_VERSION_MAJOR}::Svg AND QT_VERSION_MAJOR VERSION_GREATER_EQUAL 6)
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS SvgWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::SvgWidgets
)
endif()

if(TARGET Qt${QT_VERSION_MAJOR}::Multimedia)
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS MultimediaWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::MultimediaWidgets
)
endif()

if(TARGET Qt${QT_VERSION_MAJOR}::Quick)
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS QuickWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::QuickWidgets
)
endif()

if(TARGET Qt${QT_VERSION_MAJOR}::WebKit)
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS WebKitWidgets REQUIRED)
target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::WebKitWidgets
)
endif()

file(GLOB PUBLIC_HEADER *.h)

set_target_properties(${PROJECT_NAME} PROPERTIES
OUTPUT_NAME PythonQt-QtAll-${PYTHONQT_SUFFIX}
PUBLIC_HEADER "${PUBLIC_HEADER}"
)

if(MSVC)
target_compile_options(${PROJECT_NAME} PRIVATE "/bigobj")
elseif(MINGW)
target_compile_options(${PROJECT_NAME} PRIVATE "-Wa,-mbig-obj")
endif()

include(GNUInstallDirs)
install(TARGETS ${PROJECT_NAME}
BUNDLE DESTINATION .
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)
59 changes: 59 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
project(Core LANGUAGES CXX)

set(CMAKE_AUTOMOC ON)

find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Core Widgets REQUIRED)
find_package(Python3 COMPONENTS Development REQUIRED)

file(GLOB SOURCES *.h *.cpp)

if(BUILD_SHARED_LIBS)
add_library(${PROJECT_NAME} SHARED)
else()
add_library(${PROJECT_NAME} STATIC)
endif()

file(GLOB GENERATE_SOURCES
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_core_builtin/*.h
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_core_builtin/*.cpp
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_gui_builtin/*.h
${PYTHONQT_GENERATED_PATH}/com_trolltech_qt_gui_builtin/*.cpp
)

target_sources(${PROJECT_NAME} PRIVATE
${SOURCES}
${GENERATE_SOURCES}
)

file(GLOB PUBLIC_HEADER *.h)

set_target_properties(${PROJECT_NAME} PROPERTIES
OUTPUT_NAME PythonQt-${PYTHONQT_SUFFIX}
PUBLIC_HEADER "${PUBLIC_HEADER}"
)

target_link_libraries(${PROJECT_NAME} PUBLIC
Qt${QT_VERSION_MAJOR}::Core
Qt${QT_VERSION_MAJOR}::CorePrivate
Qt${QT_VERSION_MAJOR}::Widgets
Python3::Python
)

target_compile_definitions(${PROJECT_NAME} PRIVATE PYTHONQT_EXPORTS PYTHONQT_CATCH_ALL_EXCEPTIONS)

target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_LIST_DIR})

if(MSVC)
target_compile_options(${PROJECT_NAME} PRIVATE "/bigobj")
elseif(MINGW)
target_compile_options(${PROJECT_NAME} PRIVATE "-Wa,-mbig-obj")
endif()

include(GNUInstallDirs)
install(TARGETS ${PROJECT_NAME}
BUNDLE DESTINATION .
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)
22 changes: 22 additions & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
project(tests LANGUAGES CXX)

set(CMAKE_AUTOMOC ON)

find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Widgets Test REQUIRED)

file(GLOB SOURCES *.h *.cpp)

add_executable(${PROJECT_NAME})

target_sources(${PROJECT_NAME} PRIVATE
${SOURCES}
)

target_link_libraries(${PROJECT_NAME} PRIVATE
Qt${QT_VERSION_MAJOR}::Widgets
Qt${QT_VERSION_MAJOR}::Test
Core
QtAll
)

add_test(NAME ${PROJECT_NAME} COMMAND ${PROJECT_NAME})
Loading