Skip to content

Fix that registered classes are not added to the designated package #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix that registered classes are not added to the designated package #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/PythonQt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,14 +558,15 @@ void PythonQtPrivate::registerClass(const QMetaObject* metaobject, const char* p
PythonQtClassInfo* parentInfo = lookupClassInfoAndCreateIfNotPresent(m->superClass()->className());
info->addParentClass(PythonQtClassInfo::ParentClassInfo(parentInfo));
}
} else if (first && module) {
} else if (first && (module || (package && package[0]))) {
// There is a wrapper already, but if we got a module, we want to place the wrapper into that module as well,
// since it might have been placed into "private" earlier on.
// If the wrapper was already added to module before, it is just readded, which does no harm.
PyObject* classWrapper = info->pythonQtClassWrapper();
// AddObject steals a reference, so we need to INCREF
Py_INCREF(classWrapper);
if (PyModule_AddObject(module, info->className(), classWrapper) < 0) {
PyObject* pack = module ? module : packageByName(package); // same logic like in createPythonQtClassWrapper
if (PyModule_AddObject(pack, info->className(), classWrapper) < 0) {
Py_DECREF(classWrapper);
}
}
Expand Down
Loading