Fix warning related to use of qrand() when building against Qt 5.15 #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Qt 5.15, the `qrand` function has been deprecated in favor of `QRandomGenerator`. This change updates `PythonQtStdDecorators.h` to use `QRandomGenerator` when building against Qt 5.15 or later. See qt/qtbase@b3c0e9afa ("Deprecate qrand/qsrand", 2001-09-17) (cherry picked from commit commontk/PythonQt@c1579e2)
jcfr
force-pushed
the
backport-commontk/fix-qt5.15-qrand-deprecation
branch
from
6ad25bf to
24cf679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Qt 5.15, the
qrandfunction has been deprecated in favor ofQRandomGenerator. This change updatesPythonQtStdDecorators.hto useQRandomGeneratorwhen building against Qt 5.15 or later.See qt/qtbase@b3c0e9afa ("Deprecate qrand/qsrand", 2001-09-17)
Note
For reference, those patches were developed in the context of the
commontk/PythonQtfork.Cherry picked from commits commontk/PythonQt@c1579e2