fix: Address warnings with QSet::fromList in Qt 5.15 #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Qt 5.15, the conversion functions between QList and QSet (e.g., `QSet::fromList`) have been deprecated in favor of range constructors. This change updates the code to use the new range constructors to avoid deprecation warnings starting from Qt 5.14 (instead of Qt 6) Related upstream Qt commits: * qt/qtbase@92f984273 ("Deprecate conversion functions between QList and QSet", 2019-05-07) * qt/qtbase@e59e5643b ("Use QT_DEPRECATED_X instead of Q_DECL_DEPRECATED_X", 2020-02-25) (cherry picked from commit commontk/PythonQt@630e376)
mrbean-bremen
approved these changes
Sep 1, 2025
jcfr
deleted the
backport-commontk/fix-qt5.15-qset-fromlist-deprecation-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Qt 5.15, the conversion functions between QList and QSet (e.g.,
QSet::fromList) have been deprecated in favor of range constructors.This change updates the code to use the new range constructors to avoid deprecation warnings starting from Qt 5.14 (instead of Qt 6)
Related upstream Qt commits:
Note
For reference, those patches were developed in the context of the
commontk/PythonQtfork.Cherry picked from commits commontk/PythonQt@630e37667