fix(PythonQt): Explicitly support immortals introduced in Python >= 3.12 #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches to using the `Py_RETURN_*` macros which expand to the expected constructs. This helps avoid a no-op (and misleading) call to `Py_INCREF()` when building against Python >= 3.12. - `Py_RETURN_NOTIMPLEMENTED` was introduced in Python 3.3 through python/cpython@7d2f9e13424 ("Add Py_RETURN_NOTIMPLEMENTED macro. Fixes #12724.", 2011-08-10) - `Py_RETURN_TRUE`, `Py_RETURN_FALSE` and `Py_RETURN_NONE` were introduced in Python 2.4 through python/cpython@d05235ec49d ("Defined macros Py_RETURN_(TRUE|FALSE|NONE) as helper functions for returning the specified value. All three Py_INCREF the singleton and then return it.", 2003-10-19) References: * https://docs.python.org/3/glossary.html#term-immortal * https://peps.python.org/pep-0683/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches to using the
Py_RETURN_*macros which expand to the expected constructs. This helps avoid a no-op (and misleading) call toPy_INCREF()when building against Python >= 3.12.Py_RETURN_NOTIMPLEMENTEDwas introduced in Python 3.3 through python/cpython@7d2f9e13424 ("Add Py_RETURN_NOTIMPLEMENTED macro. Fixes #12724.", 2011-08-10)Py_RETURN_TRUE,Py_RETURN_FALSEandPy_RETURN_NONEwere introduced in Python 2.4 through python/cpython@d05235ec49d ("Defined macros Py_RETURN_(TRUE|FALSE|NONE) as helper functions for returning the specified value. All three Py_INCREF the singleton and then return it.", 2003-10-19)References: