Skip to content

Fix compilation issues on macOS by conditionally undefining ctype macros #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

Fix compilation issues on macOS by conditionally undefining ctype macros #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8056e58
fix(PythonQtPythonInclude): Undefine C <ctype> macros after Python.h …
pieper Jul 12, 2012
03cc7a4
fix(PythonQtPythonInclude): conditionally #undef ctype macros only on…
jcfr Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/PythonQtPythonInclude.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,19 @@
#define PyBytes_FromStringAndSize PyString_FromStringAndSize
#endif

// Avoid clashes with libstdc++ <locale> by undefining ctype macros
// that CPython may introduce on macOS when the UTF-8 ctype quirk is enabled.
// (_PY_PORT_CTYPE_UTF8_ISSUE is defined by CPython’s pyport.h; we apply these
// undefs only in C++ builds.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Searching for this reveals a number of similar issues in CPython itself, which they seem to have resolved by using the macros from pyctype.h like Py_ISALPHA etc.

#if defined(_PY_PORT_CTYPE_UTF8_ISSUE) && defined(__cplusplus)
#undef isalnum
#undef isalpha
#undef islower
#undef isspace
#undef isupper
#undef tolower
#undef toupper
#endif

#endif

Loading