fix: Update main function signature to be consistent across generator, test and examples #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the type of the `argv` parameter in the `main` function to match the expected signature for integration with the CMake testing framework. By default, the test driver expects the main function to have the following signature: ``` typedef int (*MainFuncPointer)(int, char* []); ``` See https://github.com/Kitware/CMake/blob/master/Templates/TestDriver.cxx.in This fixes a link error when building PythonQtCppTests on Windows: ``` 1>PythonQtCppTests.obj : error LNK2001: unresolved external symbol "int __cdecl tests_PythonQtTestMain(int,char * * const)" (?tests_PythonQtTestMain@@YAHHQEAPEAD@Z) 1>C:\temp\PythonQt-build\Debug\PythonQtCppTests.exe : fatal error LNK1120: 1 unresolved externals ``` (cherry picked from commit commontk/PythonQt@aa1a16f)
This change ensures that the main function signatures in all example files are consistent.
jcfr
changed the title
|
For the sake of having a "clean" CI, I suggest you choose the "Re-run failed jobs" in the GitHub UI (upper right corner) 🙏 It seems it failed for unrelated reasons. See https://github.com/MeVisLab/pythonqt/actions/runs/17484189898/job/49660095765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes ensure that the main function signatures in the generator, test and example files is consistent.
It updates the
argvparameter type fromchar **argvtochar *argv[]and resolves a specific link error encountered when buildingPythonQtCppTestson Windows.This will be helpful to integrate with the CMake/CTest testing framework. By default, the CMake test driver1 expects the main function to have the following signature:
This will fix link errors like the following when building
PythonQtCppTestson Windows:Note
For reference, those patches were developed in the context of the
commontk/PythonQtfork.Cherry picked from commit commontk/PythonQt@aa1a16f
Footnotes
https://github.com/Kitware/CMake/blob/master/Templates/TestDriver.cxx.in ↩