Skip to content

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Sep 11, 2025

PythonQtTestCleanup:

  • Adds a new test to check the behavior when Python is finalized before calling PythonQt cleanup.
  • Consistently indent test case and use helper (_helper->runScript) everywhere

The addition of the test PythonQtTestCleanup::testPyFinalizeThenPythonQtCleanup seems to indicate that some of the changes proposed in the following pull request may not be needed:

The new test also check that the cleanup order currently used in CTK1 (and by extension Slicer2) works as expected.

Footnotes

  1. https://github.com/commontk/CTK/blob/833ae56e69d403bd0c83f2c331a32a8fd9c70285/Libs/Scripting/Python/Core/ctkAbstractPythonManager.cpp#L85-L92

  2. https://github.com/Slicer/Slicer/blob/b7ff98e7ce49d5f57ee67be3ee9b76dc03acbe95/Base/QTCore/qSlicerCorePythonManager.h

Copy link
Contributor

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mrbean-bremen mrbean-bremen merged commit 8a33ce7 into MeVisLab:master Sep 11, 2025
19 checks passed
@jcfr jcfr deleted the test-finialize-then-cleanup branch September 18, 2025 11:27
@jcfr
Copy link
Contributor Author

jcfr commented Sep 18, 2025

So that we have a green CI, I suggest you rerun the failed test associated with https://github.com/MeVisLab/pythonqt/actions/runs/17634428359/job/50107927757. It looks this was a failure related to Qt installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants