Improve PythonQt test cleanup consistency and add alternative cleanup order test #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PythonQtTestCleanup
:_helper->runScript
) everywhereThe addition of the test
PythonQtTestCleanup::testPyFinalizeThenPythonQtCleanup
seems to indicate that some of the changes proposed in the following pull request may not be needed:The new test also check that the cleanup order currently used in
CTK
1 (and by extensionSlicer
2) works as expected.Footnotes
https://github.com/commontk/CTK/blob/833ae56e69d403bd0c83f2c331a32a8fd9c70285/Libs/Scripting/Python/Core/ctkAbstractPythonManager.cpp#L85-L92 ↩
https://github.com/Slicer/Slicer/blob/b7ff98e7ce49d5f57ee67be3ee9b76dc03acbe95/Base/QTCore/qSlicerCorePythonManager.h ↩