fix: Ensure typesystem settings can be loaded from Qt resources and update CI workflow #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `build_all.txt` to reference dependent typesystem files as Qt resources and adds the missing `typesystem_uitools.xml` entry. This change removes the need to copy the `typesystem_*.xml` files alongside the generator executable or start the executable from the generator source directory.
jcfr
force-pushed
the
fix-typesystem-qt-resource-loading
branch
from
848530f to
21fe823
Compare
This allows checking that the fix integrated in the previous commit effectively works. Since by default the generator output the generated files in the parent directory, the output directory is explicitly specified to be the current directory.
jcfr
force-pushed
the
fix-typesystem-qt-resource-loading
branch
from
21fe823 to
51795d6
Compare
jcfr
changed the title
mrbean-bremen
approved these changes
Oct 27, 2025
usiems
reviewed
Oct 27, 2025
Ensure that typesystem files are loaded from the Qt resources only if not found in the specified file path. Suggested-by: Uwe Siems <[email protected]>
usiems
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the way typesystem settings are loaded by ensuring they can be referenced as Qt resources. It updates the
build_all.txtto use Qt resource paths and adds the missingtypesystem_uitools.xmlentry.Additionally, the CI workflow is updated to run the generator outside of the source directory, ensuring the changes are effective. The output directory is explicitly specified to be the current directory to avoid issues with default output paths.