fix: Crowdin proofreader events are not well triggered - Meeds-io/meeds#2655#61
Merged
sergeByishimo merged 4 commits intoMeeds-io:developfrom Jan 17, 2025
Merged
Conversation
…ds#2655 The suggestion.approved webhook from Crowdin no longer provides the proofreader information in the payload. Instead, it only includes the translator details. Now to get proofreader details, we call the Crowdin API after receiving the webhook.
AzmiTouil
requested changes
Jan 13, 2025
gamification-crowdin-services/src/main/java/io/meeds/crowdin/gamification/utils/Utils.java
Outdated
Show resolved
Hide resolved
...din-services/src/main/java/io/meeds/crowdin/gamification/storage/CrowdinConsumerStorage.java
Outdated
Show resolved
Hide resolved
...on-crowdin-services/src/main/java/io/meeds/crowdin/gamification/services/WebhookService.java
Outdated
Show resolved
Hide resolved
...ices/src/main/java/io/meeds/crowdin/gamification/plugin/SuggestionApprovedTriggerPlugin.java
Outdated
Show resolved
Hide resolved
...ation-crowdin-services/src/main/java/io/meeds/crowdin/gamification/model/RemoteApproval.java
Outdated
Show resolved
Hide resolved
Suggested Changes by @AzmiTouil
…dy of corresponding try statement - Meeds-io/meeds#2655 exception java.lang.IllegalAccessException is never thrown in body of corresponding try statement
AzmiTouil
approved these changes
Jan 17, 2025
exo-swf
pushed a commit
that referenced
this pull request
Jan 18, 2025
…ds#2655 (#61) * fix: Crowdin proofreader events are not well triggered - Meeds-io/meeds#2655 The suggestion.approved webhook from Crowdin no longer provides the proofreader information in the payload. Instead, it only includes the translator details. Now to get proofreader details, we call the Crowdin API after receiving the webhook. * fix: Suggested Changes by @AzmiTouil - Meeds-io/meeds#2655 Suggested Changes by @AzmiTouil * fix: exception java.lang.IllegalAccessException is never thrown in body of corresponding try statement - Meeds-io/meeds#2655 exception java.lang.IllegalAccessException is never thrown in body of corresponding try statement * Remove useless imports and format code --------- Co-authored-by: Azmi Touil <atouil@exoplatform.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suggestion.approved webhook from Crowdin no longer provides the proofreader information in the payload. Instead, it only includes the translator details.
Now to get proofreader details, we call the Crowdin API after receiving the webhook.