-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/routing-arp-switching tables #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tedIps Persisted the routingTableEdited flag and routingTableEditedIps array in DataRouter to track and restore manual routing table edits across reloads.
…ns with a single table button class
…address resolution
… switching tables to a dedicated tables directory
…returned by getArpTable
…ch with new switching table structure
…e entry structure
…RP, routing, and switching tables to utilize new callback signatures
…arameter for better control over entry state
…lumns with validation
…ete - track deleted entries
…alerts for entry modifications
Manuel-Pol
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
Tablecomponent and its usage across various files. The changes include adding support for row-level metadata, enabling dynamic row addition, and refining callback methods for editing and deleting rows. These updates improve flexibility and maintainability for tables in the application.Enhancements to the
TableComponent (src/graphics/basic_components/table.ts):TableRowinterface to encapsulate row data and metadata (e.g.,editedstatus). Updated therowsproperty inTableOptionsto useTableRow[]instead ofstring[][].onAddRowcallback and a new "Add Row" button in the table UI.edited-row) for rows marked as edited and updated the logic for handling editable cells. [1] [2]getRowHashto generate a key-value mapping of a row's data based on table headers. This is used for callbacks likeonEdit.Updates to ARP Table (
src/graphics/renderables/arp_table.ts):TableRowinterface, enabling metadata tracking (e.g.,editedstatus).getArpTable,removeArpTableEntry) for improved modularity.Updates to Device Info (
src/graphics/renderables/device_info.ts):TableRowfor rows and track metadata likeeditedstatus. [1] [2] [3]getRoutingTable,getSwitchingTable). [1] [2]Updates to Program Runner Info (
src/graphics/renderables/program_runner_info.ts):TableRowfor consistency and added metadata support. Updated theonDeletecallback to work with row keys (e.g., PID) instead of indices.These changes collectively improve the extensibility and usability of tables across the application while ensuring better alignment with modern design patterns.
close #150