fix speed multiplier when setting new network and change 'Switching Table' to 'Forwarding Table' #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiplier keep the same, so consistency between pause/resume button and the state of the motion in the simulator is maintained.refactor: change 'switching table' to 'forwarding table'.
pgallino
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of the bug reported in issue #250
The bug was fixed by changing the method
GlobalContext.load(). Now, in theGlobalContext.load()function, if a newspeedMultiplieris not provided, the previous value is kept, ensuring the pause/resume state remains consistent.Rename of the "Switching Table" to "Forwarding Table"
Renamed "Switching Table" to "Forwarding Table" to align with terminology used in official documentation and texts.
Closes #250