Skip to content

perf: use GraphicsContext for packets #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MegaRedHand merged 3 commits into from
Nov 14, 2024
Merged

perf: use GraphicsContext for packets #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c519368
chore: don't use deprecated functions
MegaRedHand Nov 14, 2024
a2da178
perf: use GraphicsContext for each packet
MegaRedHand Nov 14, 2024
edced94
chore: fix lint
MegaRedHand Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/types/packet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
import { FederatedPointerEvent, Graphics, Ticker } from "pixi.js";
import {
FederatedPointerEvent,
Graphics,
GraphicsContext,
Ticker,
} from "pixi.js";
import { Edge, Position } from "./edge";
import { selectElement } from "./viewportManager";
import { Colors, drawCircle } from "../utils";
import { circleGraphicsContext, Colors, ZIndexLevels } from "../utils";
import { RightBar } from "../index";

export const packetTicker = new Ticker();

const contextPerPacketType: Record<string, GraphicsContext> = {
IP: circleGraphicsContext(Colors.Green, 0, 0, 5),
ICMP: circleGraphicsContext(Colors.Red, 0, 0, 5),
};

const highlightedPacketContext = circleGraphicsContext(Colors.Violet, 0, 0, 6);

export class Packet extends Graphics {
speed: number;
progress = 0;
Expand All @@ -27,14 +39,9 @@ export class Packet extends Graphics {

this.type = type;

const packetColors: Record<string, number> = {
IP: Colors.Green, // Verde para paquetes IP
ICMP: Colors.Red, // Rojo para paquetes ICMP
};

this.color = packetColors[this.type] || Colors.White; // Color por defecto blanco
this.context = contextPerPacketType[this.type];
this.zIndex = ZIndexLevels.Packet;

drawCircle(this, this.color, 0, 0, 5);
this.speed = speed;
this.sourceId = sourceid;
this.destinationId = destinationid;
Expand Down Expand Up @@ -70,11 +77,11 @@ export class Packet extends Graphics {
}

highlight() {
drawCircle(this, Colors.Violet, 0, 0, 5);
this.context = highlightedPacketContext;
}

removeHighlight() {
drawCircle(this, this.color, 0, 0, 5);
this.context = contextPerPacketType[this.type];
}

animateAlongPath(path: Edge[], start: number): void {
Expand Down
16 changes: 7 additions & 9 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Graphics } from "pixi.js";
import { GraphicsContext } from "pixi.js";

export enum Colors {
Violet = 0x4b0082,
Expand All @@ -10,18 +10,16 @@ export enum Colors {
Black = 0x000000,
}

export function drawCircle(
graphics: Graphics,
export function circleGraphicsContext(
color: number,
x: number,
y: number,
radius: number,
) {
graphics.clear();
graphics.beginFill(color);
graphics.drawCircle(x, y, radius);
graphics.endFill();
graphics.zIndex = ZIndexLevels.Packet;
): GraphicsContext {
const graphicsCtx = new GraphicsContext();
graphicsCtx.circle(x, y, radius);
graphicsCtx.fill(color);
return graphicsCtx;
}

export enum ZIndexLevels {
Expand Down