Undo redo #81
Merged
Undo redo #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented undo and redo functionality for moving devices by integrating with the UndoRedoManager. - Moves are now registered in the UndoRedoManager through the ViewGraph's `registerMove` method. Note: - Known bugs persist in the undo/redo functionality for adding devices. These issues need to be addressed in a future commit.
- Added `reset` method to clear undo/redo buffers and notify listeners. - Implemented undo/redo functionality for deleting devices, including restoring connections. Known issue: - Connections remain statically drawn on the screen after device removal and do not update when objects are moved.
- AddEdgeMove and RemoveEdgeMove created for UndoRedoManager. Known issue: - Removing a device with connections register both the removing of the device and the removing of the connections as different UR moves. Unexpected behavior occurs. Co-authored-by: Pedro Gallino <[email protected]>
Notes: - Known bugs persisted.
Updated the drawEdge method to accept an optional EdgeId parameter. If provided, the specified EdgeId is used; otherwise, a new ID is generated automatically. Modified the addEdge method to support custom EdgeId input while maintaining compatibility with auto-generated IDs. Adjusted undo and redo logic for addEdge and removeEdge to utilize the optional EdgeId parameter, ensuring consistent edge restoration. Enhanced the undo logic for removeDevice to use the optional EdgeId when re-establishing device connections, preserving original edge IDs during reconstruction.
- When removing a device with connection, a unique UR move is registered (RemoveDeviceMove) - Refactor: AddDeviceMove and RemoveDeviceMove extends superclass AddRemoveDeviceMove. Same for edges. - Undo/Redo icons change opacity when canUndo/canRedo. Co-authored-by: Pedro Gallino <[email protected]>
MegaRedHand
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.