fix(k8s): do not overwrite cloud serverUrl with k3s when JENKINS_K8S_…#130
Merged
fix(k8s): do not overwrite cloud serverUrl with k3s when JENKINS_K8S_…#130
Conversation
…API_URL unset ensureK8sCloud() was always setting serverUrl to JENKINS_K8S_API_URL ?: 'https://k3s:6443', which overwrote startup-configured URLs and caused UnknownHostException: k3s in GHA/shared Jenkins where 'k3s' does not resolve. Only set serverUrl (and jenkinsUrl/jenkinsTunnel) when the corresponding env vars are set; otherwise preserve existing cloud configuration. Signed-off-by: Daniel Pressler <danielpr@nvidia.com>
dpressle
force-pushed
the
local_k8s_fixup
branch
from
a3ff519 to
4c49aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…API_URL unset
ensureK8sCloud() was always setting serverUrl to JENKINS_K8S_API_URL ?: 'https://k3s:6443', which overwrote startup-configured URLs and caused UnknownHostException: k3s in GHA/shared Jenkins where 'k3s' does not resolve. Only set serverUrl (and jenkinsUrl/jenkinsTunnel) when the corresponding env vars are set; otherwise preserve existing cloud configuration.