Move K8s cloud setup to init script only; remove ensureK8sCloud from Matrix#135
Merged
mike-dubman merged 1 commit intoMellanox:masterfrom Feb 23, 2026
Conversation
…Matrix - Remove ensureK8sCloud() and its call sites from Matrix.groovy so the pipeline never modifies Jenkins cloud config (bad on shared Jenkins). - Enhance jenkins-configure-k8s-and-labels.groovy: support JENKINS_K8S_NAMESPACE, set serverUrl only when JENKINS_K8S_API_URL is provided (GHA passes it; avoid default on shared Jenkins). - Pass JENKINS_K8S_NAMESPACE from local_gha_ci.sh into Jenkins container. - Document in USERGUIDE that Kubernetes clouds must be pre-configured. Co-authored-by: Cursor <cursoragent@cursor.com>
76f0d05 to
bcc7c40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureK8sCloud()and its call sites from Matrix.groovy so the pipeline never modifies Jenkins cloud config (undesirable on shared Jenkins)..github/scripts/jenkins-configure-k8s-and-labels.groovy) to configure Kubernetes clouds at startup (GHA/local only).JENKINS_K8S_NAMESPACE, setserverUrlonly whenJENKINS_K8S_API_URLis provided.JENKINS_K8S_NAMESPACEfromlocal_gha_ci.shinto the Jenkins container.Local test (
scripts/local_gha_ci.sh) passes.