Skip to content

Conversation

@a-meynard
Copy link
Contributor

fixes #86

reimplement #87 to resolve conflicts

@sonarqubecloud
Copy link

@a-meynard
Copy link
Contributor Author

a-meynard commented Nov 18, 2024

Hello @edgarrmondragon 👋

Here is a PR that resolve conflicts that previous one had. I merged on legacy-stable as this is the default branch. Tell me if I should merge on main or something else :)

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

Thank you very much !

@edgarrmondragon
Copy link
Member

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

That's safe to ignore, and shouldn't even run on PRs from forks anyway 😅

@edgarrmondragon
Copy link
Member

Thanks @a-meynard!

@edgarrmondragon edgarrmondragon merged commit cb5f5a2 into MeltanoLabs:legacy-stable Nov 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Optionally) include retried GitLab jobs

2 participants