Open
Conversation
Member
edgarrmondragon
left a comment
There was a problem hiding this comment.
Thanks @rkravinder05, just one question about where token should be passed to the connector?
Links
| msg = "OAuth access token is required but not provided or is empty" | ||
| raise ConfigValidationError(msg) | ||
| params["authenticator"] = "oauth" | ||
| params["token"] = oauth_token |
Member
There was a problem hiding this comment.
We're passing the token in two places: here and in line 280. We probably only need one, can you confirm?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OAuth 2.0 Token Authentication Support
What's Added
Why External Token Management?
Users generate OAuth tokens outside of Meltano. This approach provides:
Configuration