Merged
Conversation
Recent updates include: Updated feature request template and documentation links/images Added structure reorganizer and conflict resolver functionality Implemented OpenAI memory integration with evaluation guide Updated memory reader with bug fixes Key changes: Template improvements, new conflict resolution tools, memory system enhancements, and bug fixes.
## Description Bug Fixes: Fixed reorganizer bugs and argument errors Resolved None issue in reorganizer queue Updated Python version constraints New Features: Added support for multiple embedders (Ark/Volcengine, Universal API) Introduced Neo4j database integration and sharing capabilities Added evaluation pipeline (longmemeval) Implemented multi-language support and customizable system prompts Added MCP (Model Context Protocol) server support with client demo Improvements: Enhanced memory management with ID returns and clustering optimizations Simplified user onboarding with basic memos Expanded LLM API support and optimized dependency management Added development tools (download examples, issue templates, stale management) Documentation & DevOps: Updated issue/PR templates and workflows Improved multi-user example implementations with significant additions to embedding support, database backends, and user experience improvements.
- Fix TypeError when calling MOSProduct.chat() method - MOSCore.chat() expects _build_system_prompt(memories, base_prompt=...) - MOSProduct._build_system_prompt had incompatible signature (user_id, memories) - Updated signature to match parent class interface - Removed unused user_id parameter from method
* feat: rewrite and reinforce query * feat: make internet search optional
feat: finish rewrite query
fridayL
requested changes
Jul 25, 2025
Collaborator
fridayL
left a comment
fridayL
left a comment
There was a problem hiding this comment.
please resolve conflicts and ci code
…mTensor#146) ## Description Summary: Fix MOSProduct._build_system_prompt method signature mismatch that caused TypeError when calling MOSProduct.chat(). The child class method signature didn't match what the parent MOSCore class expected, breaking inheritance contract. Fix: #(no existing issue - this was discovered during development) Docs Issue/PR: (not applicable - internal bug fix) Reviewer: @(leave blank if you don't know who reviews PRs in this repo) ## Checklist: - [x] I have performed a self-review of my own code | 我已自行检查了自己的代码 - [ ] I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释 - [ ] I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常 - [ ] I have created related documentation issue/PR in [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) (if applicable) | 我已在 [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) 中创建了相关的文档 issue/PR（如果适用） - [ ] I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR（如果适用） - [ ] I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人
…ic into new-rewrite-query
tangg555
pushed a commit
to tangg555/MemOS
that referenced
this pull request
Jul 29, 2025
* fix: align MOSProduct._build_system_prompt signature with MOSCore - Fix TypeError when calling MOSProduct.chat() method - MOSCore.chat() expects _build_system_prompt(memories, base_prompt=...) - MOSProduct._build_system_prompt had incompatible signature (user_id, memories) - Updated signature to match parent class interface - Removed unused user_id parameter from method * feat: rewrite query before searching memories * fix: JsonDecodeError * fix: fix prompt * ran format * feat: rewrite and reinforce query * feat: rewrite and reinforce query * feat: make internet search optional * fix: disable rewrite query seperately * feat: finish rewrite query * fix: avoid senseitive content in the memories * fix: test bug in tree_task_goal_parser * fix: info is None bug * fix: bug in nebula get_by_metadata * fix: add info to memos_core unittest --------- Co-authored-by: chunyu li <78344051+fridayL@users.noreply.github.com> Co-authored-by: muzzlol <muzxmmilkhxn@gmail.com> Co-authored-by: CaralHsi <caralhsi@gmail.com>
tianxing02
pushed a commit
to tianxing02/MemOS
that referenced
this pull request
Feb 24, 2026
* fix: align MOSProduct._build_system_prompt signature with MOSCore - Fix TypeError when calling MOSProduct.chat() method - MOSCore.chat() expects _build_system_prompt(memories, base_prompt=...) - MOSProduct._build_system_prompt had incompatible signature (user_id, memories) - Updated signature to match parent class interface - Removed unused user_id parameter from method * feat: rewrite query before searching memories * fix: JsonDecodeError * fix: fix prompt * ran format * feat: rewrite and reinforce query * feat: rewrite and reinforce query * feat: make internet search optional * fix: disable rewrite query seperately * feat: finish rewrite query * fix: avoid senseitive content in the memories * fix: test bug in tree_task_goal_parser * fix: info is None bug * fix: bug in nebula get_by_metadata * fix: add info to memos_core unittest --------- Co-authored-by: chunyu li <78344051+fridayL@users.noreply.github.com> Co-authored-by: muzzlol <muzxmmilkhxn@gmail.com> Co-authored-by: CaralHsi <caralhsi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary: rewrite query according to the context before searching memories
Reviewer: @CaralHsi
Checklist: