fix(eval): delete about memos redundant search branches#35
Merged
Ki-Seki merged 11 commits intoMemTensor:devfrom Jul 9, 2025
Merged
fix(eval): delete about memos redundant search branches#35Ki-Seki merged 11 commits intoMemTensor:devfrom
Ki-Seki merged 11 commits intoMemTensor:devfrom
Conversation
| context, duration_ms = zep_search(client, query, conv_id, top_k) | ||
| elif frame == "memos": | ||
| context, duration_ms = memos_search(client, query) | ||
| elif frame == "mem0": |
There was a problem hiding this comment.
With the memos branch removed, passing frame="memos" will fall through and leave context and duration_ms uninitialized, causing a runtime error. Consider adding an else clause to explicitly handle unsupported frame values or raise a clear error.
Member
|
This branch is out of date with the base branch. Please update it. 该分支与基础分支不同步，请更新它。 |
Contributor
Author
|
@Ki-Seki have updated the branch. |
tianxing02
pushed a commit
to tianxing02/MemOS
that referenced
this pull request
Feb 24, 2026
* feat(eval): add eval dependencies * feat(eval): add configs example * docs(eval): update README.md * feat(eval): remove the dependency (pydantic) * feat(eval): add run locomo eval script * fix(eval): delete about memos redundant search branches * chore: fix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist