Skip to content

fix: params error of access validation of share_cube_with_user function. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: params error of access validation of share_cube_with_user function. #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/memos/mem_os/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,14 +1061,16 @@ def share_cube_with_user(self, cube_id: str, target_user_id: str) -> bool:
Returns:
bool: True if successful, False otherwise.
"""
# Validate current user has access to this cube
self._validate_cube_access(cube_id, target_user_id)

# Validate target user exists
if not self.user_manager.validate_user(target_user_id):
raise ValueError(f"Target user '{target_user_id}' does not exist or is inactive.")

return self.user_manager.add_user_to_cube(target_user_id, cube_id)
# Validate current user has access to this cube
if not self.user_manager.validate_user_cube_access(target_user_id, cube_id):
return self.user_manager.add_user_to_cube(target_user_id, cube_id)
else:
return True

def get_query_rewrite(self, query: str, user_id: str | None = None):
"""
Expand Down