refactor: Consolidate backward compatibility into API models; simplify handler logic#520
Merged
CaralHsi merged 17 commits intoMemTensor:devfrom Nov 24, 2025
Merged
Conversation
## Description <!-- Please include a summary of the changes below; Fill in the issue number that this PR addresses (if applicable); Fill in the related MemOS-Docs repository issue or PR link (if applicable); Mention the person who will review this PR (if you know who it is); Replace (summary), (issue), (docs-issue-or-pr-link), and (reviewer) with the appropriate information. 请在下方填写更改的摘要； 填写此 PR 解决的问题编号（如果适用）； 填写相关的 MemOS-Docs 仓库 issue 或 PR 链接（如果适用）； 提及将审查此 PR 的人（如果您知道是谁）； 替换 (summary)、(issue)、(docs-issue-or-pr-link) 和 (reviewer) 为适当的信息。 --> Summary: (summary) Fix: #(issue) Docs Issue/PR: (docs-issue-or-pr-link) Reviewer: @(reviewer) ## Checklist: - [ ] I have performed a self-review of my own code | 我已自行检查了自己的代码 - [ ] I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释 - [ ] I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常 - [ ] I have created related documentation issue/PR in [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) (if applicable) | 我已在 [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) 中创建了相关的文档 issue/PR（如果适用） - [ ] I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR（如果适用） - [ ] I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人
## Description <!-- Please include a summary of the changes below; Fill in the issue number that this PR addresses (if applicable); Fill in the related MemOS-Docs repository issue or PR link (if applicable); Mention the person who will review this PR (if you know who it is); Replace (summary), (issue), (docs-issue-or-pr-link), and (reviewer) with the appropriate information. 请在下方填写更改的摘要； 填写此 PR 解决的问题编号（如果适用）； 填写相关的 MemOS-Docs 仓库 issue 或 PR 链接（如果适用）； 提及将审查此 PR 的人（如果您知道是谁）； 替换 (summary)、(issue)、(docs-issue-or-pr-link) 和 (reviewer) 为适当的信息。 --> Summary: (summary) Fix: #(issue) Docs Issue/PR: (docs-issue-or-pr-link) Reviewer: @(reviewer) ## Checklist: - [ ] I have performed a self-review of my own code | 我已自行检查了自己的代码 - [ ] I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释 - [ ] I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常 - [ ] I have created related documentation issue/PR in [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) (if applicable) | 我已在 [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) 中创建了相关的文档 issue/PR（如果适用） - [ ] I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR（如果适用） - [ ] I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人
…ields - Add custom_tags field for user-defined tags (e.g., ['Travel', 'family']) that can be used as search filters - Add info field for additional metadata (agent_id, app_id, source_type, etc.) with all keys usable as search filters - Add is_feedback field to indicate if the request represents user feedback - Reorganize fields with category comments for better readability - Mark async_mode as required with default value 'async' - Mark mem_cube_id, memory_content, doc_path, and source as deprecated - Enhance field descriptions for better API documentation
… and documentation - Reorganize fields with clear section comments (Basic inputs, Cube scoping, Search mode, etc.) - Add comprehensive field descriptions for better API documentation - Add new 'filter' field for structured filter conditions with support for logical operators, comparisons, and string operations - Add 'pref_top_k' and 'include_preference' fields for preference memory handling - Mark 'mem_cube_id' as deprecated, recommend 'readable_cube_ids' for multi-cube search - Make 'user_id' required field (was optional) - Add validation constraints (e.g., top_k >= 1) - Improve backward compatibility notes and internal field descriptions - Add 'threshold' field for internal similarity threshold control
…db_api_param_entry
…si/MemOSRealPublic into feat/knowledge_db_api_param_entry
CaralHsi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
This PR centralizes all backward-compatibility handling for deprecated fields directly into the API request models (APISearchRequest, APIADDRequest) using Pydantic model_validator.
By doing this, handler and cube-view layers now receive normalized, clean request data, without needing to check old parameters (mem_cube_id, memory_content, doc_path, operation, etc.).
This greatly simplifies internal logic and ensures consistent behavior across all code paths.
Fix: #(issue)
Docs Issue/PR: (docs-issue-or-pr-link)
Reviewer: @(reviewer)
Checklist: