fix(agno): handle streaming mode in InvokeAsync to prevent pickle error #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MemoriLabs#214 - Error: cannot pickle '_thread.RLock' object when using OpenAIChat with Memori + Agno in streaming mode. The issue occurred because InvokeAsync was trying to call handle_post_response() on the raw stream object, which contains unpicklable _thread.RLock objects. The fix detects when stream=True is in kwargs and returns a wrapped async generator that: 1. Iterates through the stream and yields each chunk 2. Collects chunks into raw_response using merge_chunk 3. Only calls handle_post_response after the stream is fully consumed This matches the behavior of InvokeAsyncStream but allows InvokeAsync to handle both streaming and non-streaming scenarios dynamically.
Collaborator
|
@KarthikeyaKollu Thanks for the contribution! The team will review this PR later in the week and provide feedback if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214 - Error: cannot pickle '_thread.RLock' object when using OpenAIChat with Memori + Agno in streaming mode.
The issue occurred because InvokeAsync was trying to call handle_post_response() on the raw stream object, which contains unpicklable _thread.RLock objects.
The fix detects when stream=True is in kwargs and returns a wrapped async generator that:
This matches the behavior of InvokeAsyncStream but allows InvokeAsync to handle both streaming and non-streaming scenarios dynamically.