Ya/clean china cicd #1624
Merged
Ya/clean china cicd #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Checkout InstructionsTo test this PR locally, use one of these methods: Option 1: GitHub CLI (Recommended)gh pr checkout 1624Option 2: Direct checkoutgit fetch origin ya/clean-china-cicd
git checkout ya/clean-china-cicd |
Deploying mentra-live-ota-site with
|
| Latest commit: |
add1273
|
| Status: | ⚡️ Build in progress... |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 22988493 | Triggered | Generic High Entropy Secret | 9ee827e | .github/workflows/china-deploy-static-websites-dev.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
yagarwal1307
force-pushed
the
ya/clean-china-cicd
branch
from
1ea5ecf to
271220f
Compare
Deploying mentra-store-dev with
|
| Latest commit: |
add1273
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16aa6a26.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://ya-clean-china-cicd.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
5f1277e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9525668.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://ya-clean-china-cicd.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
5f1277e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed3b1271.augmentos-e84.pages.dev |
| Branch Preview URL: | https://ya-clean-china-cicd.augmentos-e84.pages.dev |
isaiahb
approved these changes
Dec 5, 2025
Contributor
isaiahb
left a comment
isaiahb
left a comment
There was a problem hiding this comment.
LGTM!
left a few nitpicks, but not crucial so feel free to ignore those for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.