Ya/rewrite nex sgc #1822

yagarwal1307 · 2026-01-05T10:20:16Z

No description provided.

cloudflare-workers-and-pages · 2026-01-08T12:13:25Z

Deploying mentra-live-ota-site with Cloudflare Pages

Latest commit:	`b16d3ad`
Status:	✅ Deploy successful!
Preview URL:	https://50e2a5fa.mentra-live-ota-site.pages.dev
Branch Preview URL:	https://ya-rewrite-nex-sgc.mentra-live-ota-site.pages.dev

View logs

cloudflare-workers-and-pages · 2026-01-08T12:14:47Z

Deploying mentra-store-dev with Cloudflare Pages

Latest commit:	`b16d3ad`
Status:	✅ Deploy successful!
Preview URL:	https://96c4712f.augmentos-appstore-2.pages.dev
Branch Preview URL:	https://ya-rewrite-nex-sgc.augmentos-appstore-2.pages.dev

View logs

cloudflare-workers-and-pages · 2026-01-08T12:16:03Z

Deploying dev-augmentos-console with Cloudflare Pages

Latest commit:	`b16d3ad`
Status:	✅ Deploy successful!
Preview URL:	https://87bf9abb.dev-augmentos-console.pages.dev
Branch Preview URL:	https://ya-rewrite-nex-sgc.dev-augmentos-console.pages.dev

View logs

cloudflare-workers-and-pages · 2026-01-08T12:17:15Z

Deploying prod-augmentos-account with Cloudflare Pages

Latest commit:	`b16d3ad`
Status:	✅ Deploy successful!
Preview URL:	https://44d055bb.augmentos-e84.pages.dev
Branch Preview URL:	https://ya-rewrite-nex-sgc.augmentos-e84.pages.dev

View logs

aisraelov · 2026-01-15T17:16:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8c05132d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt

The version query packet was being generated but never actually sent to the glasses, causing glasses_protobuf_version to stay unset after connection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

mobile/modules/core/android/src/main/java/com/mentra/core/Bridge.kt

gitguardian · 2026-01-20T08:36:03Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
22988493	Triggered	Generic High Entropy Secret	`b16d3ad`	.github/workflows/china-deploy-static-websites-dev.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

aisraelov · 2026-01-21T04:11:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b16d3ad808

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt

mobile/modules/core/android/src/main/java/com/mentra/core/utils/NexSGCUtils.kt

aisraelov · 2026-01-23T04:45:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 983765f5a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-23T04:54:00Z

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt

+            val bmp = BitmapFactory.decodeByteArray(bmpData, 0, bmpData.size)
+
+            displayBitmapImageForNexGlasses(bmpData, bmp.width,  bmp.height)


Handle null bitmap decode before using width/height

In MentraNex.displayBitmap, BitmapFactory.decodeByteArray can return null for malformed/unsupported image data, but the code immediately dereferences bmp.width/bmp.height. This will crash the app whenever callers pass invalid base64 or non-decodable bytes. Add a null check (as other SGCs do) and return false instead of proceeding.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-23T04:54:00Z

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt

+    private fun reSendImageMissingChunks(missingChunksIndexList: List<Int>) {
+        if (!isImageSendProgressing || currentImageChunks.isEmpty() || missingChunksIndexList.isEmpty()) {
+            return


Allow image resend when transfer reports missing chunks

reSendImageMissingChunks exits unless isImageSendProgressing is true, but this flag is never set to true when an image transfer starts (it’s only cleared). As a result, when the glasses return INCOMPLETE, the missing chunks are never resent and the image remains incomplete. Set the flag when starting a transfer or remove the guard so the resend path can run.

Useful? React with 👍 / 👎.

chore: rewrite nex sgc

6175911

yagarwal1307 requested a review from a team as a code owner January 5, 2026 10:20

yagarwal1307 changed the base branch from main to dev January 5, 2026 10:20

yagarwal1307 marked this pull request as draft January 5, 2026 10:21

yagarwal1307 added 9 commits January 6, 2026 00:17

chore: refactor and cleanup nex sgc

b9b3bec

chore: refactor the code more

2017183

chore: refactor the constants

2fb5916

fix: fix imports

c6c17c4

fix: fix some of the errors

58356f1

fix: fix compilation erros

dc6377c

chore: fix connection bugs

35c12d3

chore: fix the nex developer settings

0ba7f1c

Merge branch 'dev' into ya/rewrite-nex-sgc

7c78a1d

fix: fix the interface

a65262a

yagarwal1307 marked this pull request as ready for review January 9, 2026 07:11

yagarwal1307 added 5 commits January 9, 2026 16:35

chore: fix the nex ble filtering

b3be066

chore: fix nex developer settings schema versions

a8c2fc3

chore: merge dev into nex sgc

75f7665

chore: replace m dashes with normal

6a1a006

Merge branch 'dev' into ya/rewrite-nex-sgc

b8c0513

chatgpt-codex-connector bot reviewed Jan 15, 2026

View reviewed changes

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt Show resolved Hide resolved

Fix missing sendDataSequentially call for protobuf version request

884edc4

The version query packet was being generated but never actually sent to the glasses, causing glasses_protobuf_version to stay unset after connection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fossephate reviewed Jan 15, 2026

View reviewed changes

mobile/modules/core/android/src/main/java/com/mentra/core/Bridge.kt Show resolved Hide resolved

yagarwal1307 added 2 commits January 20, 2026 13:43

Merge branch 'dev' into ya/rewrite-nex-sgc

06eeaea

chore: refactor nex event functions

34f66fc

Merge branch 'dev' into ya/rewrite-nex-sgc

b16d3ad

chatgpt-codex-connector bot reviewed Jan 21, 2026

View reviewed changes

mobile/modules/core/android/src/main/java/com/mentra/core/sgcs/MentraNex.kt Outdated Show resolved Hide resolved

mobile/modules/core/android/src/main/java/com/mentra/core/utils/NexSGCUtils.kt Show resolved Hide resolved

yagarwal1307 added 4 commits January 21, 2026 13:42

fix: fix duplicate commands and send proper clear display command

6cf4583

fix: fix the nex glasses mic issue

62bf58d

Merge branch 'dev' into ya/rewrite-nex-sgc

b536a3a

fix: fix the display bitmap image function call

983765f

chatgpt-codex-connector bot reviewed Jan 23, 2026

View reviewed changes

aisraelov merged commit e374b3d into dev Jan 23, 2026
6 of 8 checks passed

		val bmp = BitmapFactory.decodeByteArray(bmpData, 0, bmpData.size)

		displayBitmapImageForNexGlasses(bmpData, bmp.width, bmp.height)

Ya/rewrite nex sgc #1822

Ya/rewrite nex sgc #1822

Uh oh!

Conversation

yagarwal1307 commented Jan 5, 2026

Uh oh!

cloudflare-workers-and-pages bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying mentra-live-ota-site with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying mentra-store-dev with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying dev-augmentos-console with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying prod-augmentos-account with Cloudflare Pages

Uh oh!

aisraelov commented Jan 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

gitguardian bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

aisraelov commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aisraelov commented Jan 23, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cloudflare-workers-and-pages bot commented Jan 8, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 8, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 8, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 8, 2026 •

edited

Loading

gitguardian bot commented Jan 20, 2026 •

edited

Loading