Skip to content

Removing SoundCloud logic from this branch #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsaiyilien wants to merge 1 commit into
base: Development
Choose a base branch
from
Open

Removing SoundCloud logic from this branch #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Streamus Chrome Extension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@
<Content Include="src\js\background\model\dataSourceManager.js" />
<Content Include="src\js\background\model\debugManager.js" />
<Content Include="src\js\background\model\relatedSongsManager.js" />
<Content Include="src\js\background\model\soundCloudAPI.js" />
<Content Include="src\js\background\model\stream.js" />
<Content Include="src\js\background\view\backgroundAreaView.js" />
<Content Include="src\js\background\collection\playlistItems.js" />
Expand Down
3 changes: 0 additions & 3 deletions src/js/background/model/backgroundArea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
var Search = require('background/model/search');
var Settings = require('background/model/settings');
var SignInManager = require('background/model/signInManager');
var SoundCloudAPI = require('background/model/soundCloudAPI');
var Stream = require('background/model/stream');
var SyncManager = require('background/model/syncManager');
var TabManager = require('background/model/tabManager');
Expand Down Expand Up @@ -70,8 +69,6 @@

var search = new Search();

var soundCloudAPI = new SoundCloudAPI();

var chromeContextMenusManager = new ChromeContextMenusManager({
browserSettings: browserSettings,
tabManager: tabManager,
Expand Down
4 changes: 0 additions & 4 deletions src/js/background/model/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,23 +319,19 @@ define(function (require) {
},

_onYouTubePlayerChangeReady: function (model, ready) {
// TODO: This will need to be smarter w/ SoundCloud support.
this.set('ready', ready);
},

_onYouTubePlayerChangeState: function (model, youTubePlayerState) {
// TODO: This will need to be smarter w/ SoundCloud support.
var playerState = this._getPlayerState(youTubePlayerState);
this.set('state', playerState);
},

_onYouTubePlayerChangeLoading: function (model, loading) {
// TODO: This will need to be smarter w/ SoundCloud support.
this.set('loading', loading);
},

_onYouTubePlayerChangeCurrentLoadAttempt: function (model, currentLoadAttempt) {
// TODO: This will need to be smarter w/ SoundCloud support.
this.set('currentLoadAttempt', currentLoadAttempt);
},

Expand Down
2 changes: 1 addition & 1 deletion src/js/background/model/song.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

var Song = Backbone.Model.extend({
defaults: {
// ID is either a YouTube Video ID or a SoundCloud Song ID.
// ID is a YouTube Video ID.
id: '',
// Title is immutable. PlaylistItem might support editing the title, but applied to the PlaylistItem and not to Song.
title: '',
Expand Down
Loading