Allow bound functions and spending functions to take character values#509
Merged
LittleBeannie merged 2 commits intoMerck:mainfrom Mar 21, 2025
Merged
Allow bound functions and spending functions to take character values#509LittleBeannie merged 2 commits intoMerck:mainfrom
LittleBeannie merged 2 commits intoMerck:mainfrom
Conversation
Collaborator
|
xref: #408 (comment), #411, #413 |
Collaborator
Author
|
Yes, a nice side-effect of this PR is that we will be able to compare functions robustly. The character name will be resolved to function at run time, and compared to a target function that is also retrieved at run time. This avoids cases like saving I managed to delete a large object of 75 lines in the Shiny app after this PR. @LittleBeannie I think this PR is ready to merge now. I'm not sure the jargons in the news entry are accurate. Please feel free to tweak the words if necessary. |
LittleBeannie
approved these changes
Mar 21, 2025
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thank you, @yihui! This looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it much easier to design the Shiny app.