Skip to content

Commit 5913817

Browse files
ci: use gsed instead of sed (#69)
We get this warning when installing `gnu-sed` in the CI: ``` GNU "sed" has been installed as "gsed". If you need to use it as "sed", you can add a "gnubin" directory to your PATH from your bashrc like: PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH" ``` Changing the GitHub's path using `echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> "$GITHUB_PATH"` doesn't work. We can use `gsed` to fix the issue.
1 parent 052af5d commit 5913817

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ jobs:
4040
run: |
4141
npm ci
4242
brew install gnu-sed
43-
echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> "$GITHUB_PATH"
4443
4544
- name: Test
4645
run: |

.github/workflows/release.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ jobs:
1818
VERSION: ${{ github.event.release.tag_name }}
1919
run: |
2020
brew install gnu-sed
21-
echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> "$GITHUB_PATH"
2221
2322
sudo xcode-select -s /Applications/Xcode.app
2423
make

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ mergify-%-${VERSION}.zip: %
2727
rm -rf build $@
2828
cp -a src build
2929
rm -rf build/__tests__
30-
sed -i \
30+
gsed -i \
3131
-e 's/#VERSION#/$(VERSION)/g' \
3232
-e 's/$(GITHUB_DOMAIN_DEFAULT)/$(GITHUB_DOMAIN)/g' \
3333
-e 's/$(MERGIFY_DOMAIN_DEFAULT)/$(MERGIFY_DOMAIN)/g' \

0 commit comments

Comments
 (0)