Skip to content

merge queue: embarking main (83bc8b9) and #176 together #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mergify wants to merge 2 commits into from
Closed

merge queue: embarking main (83bc8b9) and #176 together #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec5c11e
fix: update PR status detection and simplify timeline section layout
sileht Feb 5, 2026
4a83a0a
Merge of #176
mergify[bot] Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions src/mergify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,24 @@ function postCommand(command) {
}

function isPullRequestOpen() {
const status = document
.querySelector("span.State")
.getAttribute("title")
.split(": ")[1];
if (!status) {
console.warn("Can't find pull request status");
// Assume it's open if we can't find the status
return "open";
const opened = document.querySelector("span[data-status=pullOpened]");
const draft = document.querySelector("span[data-status=draft]");
if (opened || draft) return true;

const oldStatusBadge = document.querySelector("span.State");
if (oldStatusBadge) {
const status = oldStatusBadge.getAttribute("title").split(": ")[1];
if (!status) {
console.warn("Can't find pull request status");
// Assume it's open if we can't find the status
return true;
}
// status can be "open", "draft", "merged" or "closed"
return ["open", "draft"].includes(status.toLowerCase());
}
// status can be "open", "draft", "merged" or "closed"
return ["open", "draft"].includes(status.toLowerCase());

// Assume it's open if we can't find the status
return true;
}

function buildBtn(command, label, tooltip, disabled) {
Expand Down Expand Up @@ -285,14 +292,10 @@ function buildLinks() {

function buildMergifySectionForTimelineActions() {
const container1 = document.createElement("div");
container1.className = "branch-action py-0 my-3 pl-0 pl-md-3 ml-md-6";
container1.id = "mergify";
container1.setAttribute("aria-label", "Mergify");

const container2 = document.createElement("div");
container2.className =
"border color-border-default rounded-2 branch-action-item js-details-container js-transitionable";
container1.appendChild(container2);
container1.className =
"border color-border-default rounded-2 branch-action-item js-details-container js-transitionable mb-3";

const title = document.createElement("h3");
title.className = "h4 status-heading";
Expand All @@ -302,11 +305,11 @@ function buildMergifySectionForTimelineActions() {
subtitle.className = "status-meta";
subtitle.textContent = "This pull request is managed by Mergify.";

container2.appendChild(buildLogoContainer());
container2.appendChild(buildLinks());
container2.appendChild(title);
container2.appendChild(subtitle);
container2.appendChild(buildButtons());
container1.appendChild(buildLogoContainer());
container1.appendChild(buildLinks());
container1.appendChild(title);
container1.appendChild(subtitle);
container1.appendChild(buildButtons());

return container1;
}
Expand Down