fix(chore): use a callable for defaults

[leocnp]

Without a callable the defaults are evaluated on import which causes unexpected errors with other commands.

[mergify]

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.

• any of:
  • -title ~= ^feat
  • label = need changelog
  • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

• title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.

• #changes-requested-reviews-by = 0
• #review-requested = 0
• #review-threads-unresolved = 0

[sileht]

Lazy loading them is a good idea.

We cannot just use a lambda otherwise cli arguments will be ignored and we will always load the default.

[sileht]

Lazy loading them is a good idea.

We cannot just use a lambda otherwise cli arguments will be ignored and we will always load the default.

I remake a couple of tests and it seems, the issue occurs only when is_flag=True

[sileht]

I reproduce the issue in a simplier app https://github.com/sileht/click-bug :

# without lambda:
$ poetry run python3 main.py work
False
$ poetry run python3 main.py work -v
True

# with lambda:
$ poetry run python3 main.py buggy
False
$ poetry run python3 main.py buggy -v
False

[leocnp]

I reproduce the issue in a simplier app https://github.com/sileht/click-bug :

# without lambda:
$ poetry run python3 main.py work
False
$ poetry run python3 main.py work -v
True

# with lambda:
$ poetry run python3 main.py buggy
False
$ poetry run python3 main.py buggy -v
False

ThanksI am not sure I understand why user input does not always prevail when it is passed but I'll take a better look to find a fix.

Pull request has been modified.