Skip to content

fix: use console print instead of log for annotation #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Dec 2, 2024
Merged

fix: use console print instead of log for annotation #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mergify_cli/ci/junit_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,8 @@ async def upload( # noqa: PLR0913, PLR0917
)

gigid = response.json()["gigid"]
console.log(f"::notice title=CI Issues report::CI_ISSUE_GIGID={gigid}")
console.print(
f"::notice title=CI Issues report::CI_ISSUE_GIGID={gigid}",
soft_wrap=True,
)
console.log("[green]:tada: File(s) uploaded[/]")
14 changes: 12 additions & 2 deletions mergify_cli/tests/ci_issues/test_junit_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,16 @@ def test_get_files_to_upload() -> None:
assert files_to_upload[0][1][1].closed


async def test_junit_upload(respx_mock: respx.MockRouter) -> None:
async def test_junit_upload(
respx_mock: respx.MockRouter,
capsys: pytest.CaptureFixture[str],
) -> None:
gigid = "eyJjaV9qb2JfaWQiOjcwNzQyLCJzaWduYXR1cmUiOiI2NjcxN2QwZDdiZjZkMzAxMmFmNGE4NWQ1YTFlZDhmYjNkNDBjYmM4MmZjZjgxZTVmNzEzNzEyZjRlZjIxOTFmIn0="
respx_mock.post(
"/v1/repos/user/repo/ci_issues_upload",
).respond(
200,
json={"gigid": "1234azertyuiop"},
json={"gigid": gigid},
)

await junit_upload_mod.upload(
Expand All @@ -149,6 +153,12 @@ async def test_junit_upload(respx_mock: respx.MockRouter) -> None:
(str(REPORT_XML),),
)

captured = capsys.readouterr()
assert (
captured.out.split("\n")[0]
== f"::notice title=CI Issues report::CI_ISSUE_GIGID={gigid}"
)


async def test_junit_upload_http_error(respx_mock: respx.MockRouter) -> None:
respx_mock.post("/v1/repos/user/repo/ci_issues_upload").respond(
Expand Down