chore: remove mode #819
Merged
chore: remove mode #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for c9587ce. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the mode field from ScopesConfig to shift responsibility for execution mode to the merge_queue on the engine side.
- Remove ScopesConfig.mode (serial/parallel)
- Keep existing fields and validation behavior (extra="forbid")
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sileht
force-pushed
the
devs/sileht/cli2-mode-foobar/I7bfa1faac35fa5547bba04cf24b941a4c7b1e700
branch
from
adb0063 to
9269365
Compare
jd
previously approved these changes
Oct 14, 2025
Contributor
|
@sileht this pull request is now in conflict 😩 |
This will be moved to merge_queue: on engine side. Change-Id: I7bfa1faac35fa5547bba04cf24b941a4c7b1e700
sileht
force-pushed
the
devs/sileht/cli2-mode-foobar/I7bfa1faac35fa5547bba04cf24b941a4c7b1e700
branch
from
9269365 to
c9587ce
Compare
remyduthu
approved these changes
Oct 14, 2025
Syffe
approved these changes
Oct 14, 2025
mergify
bot
deleted the
devs/sileht/cli2-mode-foobar/I7bfa1faac35fa5547bba04cf24b941a4c7b1e700
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be moved to merge_queue: on engine side.