chore(scopes): split and sync configuration schema #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the scopes configuration code by extracting it from the CLI module into separate modules for better organization and maintainability. The changes split configuration schema definitions into dedicated files to enable CI synchronization from the engine.
- Extracts configuration schema classes into dedicated modules
- Updates imports and references throughout the codebase
- Maintains existing functionality while improving code organization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mergify_cli/ci/scopes/config/scopes.py | Defines core scope configuration schema with enhanced documentation |
| mergify_cli/ci/scopes/config/root.py | Contains main Config class and YAML loading functionality |
| mergify_cli/ci/scopes/config/init.py | Exports all configuration classes and handles imports |
| mergify_cli/ci/scopes/cli.py | Updates imports to use new config module structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sileht
force-pushed
the
devs/sileht/cli2-other/Ib976077362efebc9f3d1548e48cbad370372ecd3
branch
from
30ed559 to
1f4c36d
Compare
sileht
force-pushed
the
devs/sileht/cli2-other/Ib976077362efebc9f3d1548e48cbad370372ecd3
branch
from
1f4c36d to
3e00797
Compare
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 1e9b576. 🟢 All jobs passed!But CI Insights is watching 👀 |
This changes split the configuration codes and sync it from the engine. This will allow to build a CI job to sync the ci/scopes/config/scopes.py file. Change-Id: Ib976077362efebc9f3d1548e48cbad370372ecd3
sileht
force-pushed
the
devs/sileht/cli2-other/Ib976077362efebc9f3d1548e48cbad370372ecd3
branch
from
3e00797 to
1e9b576
Compare
Greesb
approved these changes
Oct 15, 2025
Syffe
approved these changes
Oct 15, 2025
mergify
bot
deleted the
devs/sileht/cli2-other/Ib976077362efebc9f3d1548e48cbad370372ecd3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes split the configuration codes and sync it from the engine.
This will allow to build a CI job to sync the ci/scopes/config/scopes.py file.