Skip to content

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 15, 2025

GitHub supports dynamic outputs only if the action use "using: node".
This does not work for "using: composite" or "docker" action.

https://github.com/orgs/community/discussions/10529

The workaround is to dump the json into the output.

Then the GitHub workflow will be able to use fromJSON to read it:

if: fromJSON(steps.action.outputs.scopes).everything

Copilot AI review requested due to automatic review settings October 15, 2025 18:11
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:11 Failure
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=test (macos-15)
    • check-success=test (ubuntu-24.04)
    • check-success=test (windows-2025)

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025

🧪 CI Insights

Here's what we observed from your CI run for e97630a.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Consolidate GitHub Actions outputs into a single JSON-encoded value to simplify consumption in workflows.

  • Aggregate scope results into one output key named "scopes" with a JSON dictionary.
  • Update tests to assert the new JSON output format.
  • Introduce a constant for the output name and import json.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
mergify_cli/ci/scopes/cli.py Switch from per-scope lines to a single JSON payload under the "scopes" output; add constant and json import.
mergify_cli/tests/ci/scopes/test_cli.py Adjust test to assert the new "scopes={...}" single-line JSON output.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mergify mergify bot requested a review from a team October 15, 2025 18:14
@sileht sileht marked this pull request as draft October 15, 2025 18:27
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from e7299fb to 660d012 Compare October 15, 2025 18:33
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:33 Failure
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from 660d012 to 956596d Compare October 15, 2025 18:35
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:35 Failure
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch 3 times, most recently from 5ce0e58 to 611ba3f Compare October 15, 2025 18:57
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:57 Failure
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from 611ba3f to 66047c2 Compare October 15, 2025 18:57
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:57 Failure
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from 66047c2 to 79862f2 Compare October 15, 2025 18:59
@sileht sileht requested a review from jd October 15, 2025 18:59
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 18:59 Failure
@sileht sileht marked this pull request as ready for review October 15, 2025 18:59
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from 79862f2 to 5aece87 Compare October 15, 2025 19:07
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 15, 2025 19:07 Failure
GitHub supports dynamic outputs only if the action use "using: node".
This does not work for "using: composite" or "docker" action.

The workaround is to dump the json into the output.

Then the GitHub workflow will be able to use fromJSON to read it:

```
if: fromJSON(steps.action.outputs.scopes).everything
```

Change-Id: I294c5f828801ad06a6ed613a127ed1b9315e40aa
@sileht sileht force-pushed the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch from 5aece87 to 18bdf66 Compare October 16, 2025 07:05
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 16, 2025 07:06 Failure
jd
jd previously approved these changes Oct 16, 2025
@mergify mergify bot dismissed jd’s stale review October 16, 2025 07:15

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections October 16, 2025 07:15 Active
@mergify mergify bot requested a review from a team October 16, 2025 07:17
@mergify mergify bot merged commit 2753413 into main Oct 16, 2025
5 checks passed
@mergify mergify bot deleted the devs/sileht/step-name/I294c5f828801ad06a6ed613a127ed1b9315e40aa branch October 16, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants