chore: sync ruff rules #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I3fceec42477b484184ff76e3b323a2eb77b7303b
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ruff linter configuration to align with the engine's settings and applies the corresponding code changes. The main focus is on enabling stricter type checking, modernizing Python syntax, and enforcing better code quality standards.
Key changes:
- Updated ruff configuration to match engine settings, including Python 3.13 target, expanded rule sets, and new type-checking configurations
- Added
from __future__ import annotationsto all Python files for PEP 563 postponed evaluation - Converted many imports to TYPE_CHECKING blocks to improve runtime performance
- Updated function signatures to use keyword-only arguments for better API clarity
- Removed unnecessary noqa comments that are now covered by the updated ignore list
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated ruff configuration with expanded rule sets, new ignore patterns, and type-checking settings |
| test_binary_build.py | Added future annotations import |
| mergify_cli/utils.py | Updated function signatures with keyword-only arguments and removed noqa comments |
| mergify_cli/tests/*.py | Added future annotations and TYPE_CHECKING blocks for imports |
| mergify_cli/stack/*.py | Added future annotations, TYPE_CHECKING blocks, and keyword-only argument markers |
| mergify_cli/ci/**/*.py | Added future annotations and moved imports to TYPE_CHECKING blocks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for c36c21b. 🟢 All jobs passed!But CI Insights is watching 👀 |
Greesb
approved these changes
Oct 17, 2025
remyduthu
approved these changes
Oct 17, 2025
mergify
bot
deleted the
devs/sileht/fix-ruff/I3fceec42477b484184ff76e3b323a2eb77b7303b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the same rules we use in other projects.