refactor: move git_refs into its own module #848
Merged
+69
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Merged
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the git references detection functionality by moving it from mergify_cli.ci.scopes.git_refs_detector into its own dedicated module at mergify_cli.ci.git_refs.detector, enabling reuse for a new CLI tool.
Key changes:
- Moved
git_refs_detectormodule intomergify_cli.ci.git_refs.detector - Relocated GitHub Actions output writing for base/head refs from
scopes/cli.pyto theReferencesclass via a newmaybe_write_to_github_outputs()method - Updated all import statements and references across the codebase
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mergify_cli/tests/ci/scopes/test_cli.py | Updated imports and mock paths to use the new module location; removed base/head parameters from maybe_write_github_outputs calls |
| mergify_cli/tests/ci/git_refs/test_git_refs_detector.py | Updated imports to use new module path; added test for the new maybe_write_to_github_outputs method |
| mergify_cli/ci/scopes/cli.py | Updated import to use new module location; removed base/head output writing logic and parameters |
| mergify_cli/ci/git_refs/detector.py | Added GitHub Actions output constants and maybe_write_to_github_outputs method to References class |
| mergify_cli/ci/git_refs/cli.py | Created empty placeholder file for future CLI implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 26b0e37. 🟢 All jobs passed!But CI Insights is watching 👀 |
This modules will be reused for a new cli. Change-Id: I95fa84a430ebfb8fde19dcb1b8cd231f69502600
sileht
force-pushed
the
devs/sileht/cli-base-head/I95fa84a430ebfb8fde19dcb1b8cd231f69502600
branch
from
e7ae8ea to
26b0e37
Compare
JulianMaurin
approved these changes
Oct 29, 2025
jd
approved these changes
Oct 29, 2025
remyduthu
approved these changes
Oct 29, 2025
Contributor
|
✅ The pull request has been merged |
mergify
bot
deleted the
devs/sileht/cli-base-head/I95fa84a430ebfb8fde19dcb1b8cd231f69502600
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
This introduces `mergify ci git-refs` to get the shas the monorepo tooling must use for testing batches. Depends-On: #848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules will be reused for a new cli
mergify ci git-refgs.