-
Notifications
You must be signed in to change notification settings - Fork 11
revert: fix: don't fail when source is manual #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: fix: don't fail when source is manual #852
Conversation
Revert e8d55f3 We don't need this anymore. We want people to use git-refs + scopes-upload Change-Id: I533b6bc7e9b594755145d6d9459e28ea23fe7580
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 4426cb9. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the behavior when the manual source is configured for scopes detection. Instead of silently proceeding with no matched scopes, the code now raises an explicit error instructing users to use scopes-send or the API.
Key changes:
- Modified the
detectfunction to raise aScopesErrorwhen manual source is configured - Updated the config structure to require nested
manualkey undersource - Updated test to verify the new error-raising behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mergify_cli/ci/scopes/cli.py | Changed logic to raise ScopesError instead of treating SourceManual like None |
| mergify_cli/tests/ci/scopes/test_cli.py | Updated test configuration structure and assertions to verify the new error behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
✅ The pull request has been merged |
Revert e8d55f3
We don't need this anymore. We want people to use git-refs + scopes-upload