Skip to content

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 29, 2025

Revert e8d55f3

We don't need this anymore. We want people to use git-refs + scopes-upload

Revert e8d55f3

We don't need this anymore. We want people to use git-refs + scopes-upload

Change-Id: I533b6bc7e9b594755145d6d9459e28ea23fe7580
Copilot AI review requested due to automatic review settings October 29, 2025 09:28
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 29, 2025 09:29 Failure
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= .{48,}

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

🧪 CI Insights

Here's what we observed from your CI run for 4426cb9.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the behavior when the manual source is configured for scopes detection. Instead of silently proceeding with no matched scopes, the code now raises an explicit error instructing users to use scopes-send or the API.

Key changes:

  • Modified the detect function to raise a ScopesError when manual source is configured
  • Updated the config structure to require nested manual key under source
  • Updated test to verify the new error-raising behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
mergify_cli/ci/scopes/cli.py Changed logic to raise ScopesError instead of treating SourceManual like None
mergify_cli/tests/ci/scopes/test_cli.py Updated test configuration structure and assertions to verify the new error behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team October 29, 2025 09:31
@mergify mergify bot deployed to Mergify Merge Protections October 29, 2025 09:59 Active
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

✅ The pull request has been merged

@mergify mergify bot merged commit 43c8ccb into main Oct 29, 2025
10 checks passed
@mergify mergify bot deleted the devs/sileht/revert/I533b6bc7e9b594755145d6d9459e28ea23fe7580 branch October 29, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants