fix: don't parse error 500 #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error may not be a json message or the json message may not contains message/errors attributes. This change make the logging more generic and just print the HTTP response. Change-Id: I8fdbd8000f6bd3135705852a5eb7943d4d9d9199
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for ac2d4cb. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the HTTP error handling in check_for_status() to simplify the error reporting logic and remove the explicit sys.exit(1) call, instead relying on response.raise_for_status() to propagate exceptions.
- Removed special handling for 4xx status codes and now treats all HTTP errors (4xx and 5xx) uniformly
- Simplified error message display to show raw response text instead of parsing JSON and extracting specific fields
- Removed the
sysimport as it's no longer needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greesb
approved these changes
Oct 31, 2025
Syffe
approved these changes
Oct 31, 2025
Contributor
Queue status✅ The pull request has been merged This pull request spent 5 seconds in the queue and **** waiting for CI. Required conditions to merge
|
mergify
bot
deleted the
devs/sileht/cli-base-head/I8fdbd8000f6bd3135705852a5eb7943d4d9d9199
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error may not be a json message or the json message may not
contains message/errors attributes.
This change make the logging more generic and just print the HTTP
response.