introduce helper to normalize workspace/project roles from strings #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
requested changes
Jan 8, 2026
Contributor
varmar05
left a comment
varmar05
left a comment
There was a problem hiding this comment.
Looking good, just some minor suggestions.
|
|
||
|
|
||
| def test_string_roles(): | ||
| assert normalize_role("guest", WorkspaceRole) == WorkspaceRole.GUEST |
Contributor
There was a problem hiding this comment.
maybe use pytest parametrize
| self.check_collaborators_members_support() | ||
| role_enum = normalize_role(workspace_role, WorkspaceRole) | ||
| if role_enum is None: | ||
| raise ValueError("bad role") |
Contributor
There was a problem hiding this comment.
Let's create more user friendly message, e.g. f'Invalid role: {workspace_role}'
| mp.log.error(f"Error during tmp dir cleanup: {tmp_dir.name}: {e}") | ||
|
|
||
|
|
||
| def normalize_role(role: Union[str, Enum], enum_cls: Type[Enum]) -> Optional[Enum]: |
| """ | ||
| self.check_collaborators_members_support() | ||
|
|
||
| role_enum = normalize_role(workspace_role, WorkspaceRole) |
Contributor
There was a problem hiding this comment.
if we want to get rid of repeated code you can try to wrap this up in some decorator which would make sure that arg would be always Enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small helper function to normalize role inputs so callers can pass either a role Enum instance or a string (case/whitespace-insensitive). Invalid inputs return None, allowing the caller to handle validation consistently.
solves: #265