Skip to content

Conversation

@sirinn
Copy link

@sirinn sirinn commented Nov 29, 2020

Hi,

I added support of multiple examples and tested on attached example defs/issue192.json. I inspired myself by the response examples code and reused what I could.

Please have a look :)

@MikeRalphson
Copy link
Contributor

Thanks for the PR! The number of CI test failures indicating undefined is making its way into the output means something is probably not quite right somewhere. Could you take a look running some of the other files from defs/ with the testRunner?

@sirinn
Copy link
Author

sirinn commented Dec 1, 2020

hi, sure I will take a look later this week I can see that some cases are not covered :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants