Skip to content

Create standard rose-suite.conf for RAL3-LFRic, with all variables populated.#1190

Merged
jwarner8 merged 12 commits intomainfrom
roseconf
Mar 3, 2025
Merged

Create standard rose-suite.conf for RAL3-LFRic, with all variables populated.#1190
jwarner8 merged 12 commits intomainfrom
roseconf

Conversation

@jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Feb 21, 2025

Contains a rose-suite.conf, with variables populated. Will help users run CSET out of the box with accompanying guidance.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Feb 21, 2025
@jwarner8 jwarner8 added the documentation Improvements or additions to documentation label Feb 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Coverage

@jfrost-mo
Copy link
Member

So long as you don't use the same name as a file from the other repository (currently just rose-suite-<site>.conf), it won't be overwritten. The gitignore just stops files being added, but won't stop a file that is already tracked from being updated.

If you want to add this file to the opt directory, move it into place then run:

git add -f cset-workflow/opt/cset-workflow/rose-suite_RAL3LFRic.conf

I think optional configs act as an override on the base rose-suite.conf. As an optional config we probably want to just contain the diagnostics, and leave the user to set the data and setup config in their own rose-suite.conf. As it will be used as-is, we can drop the .example.

@jwarner8 jwarner8 marked this pull request as ready for review March 3, 2025 13:02
@jwarner8 jwarner8 requested a review from daflack March 3, 2025 13:04
Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the conf file, covers everything and works as expected. My only minor question is do we want 250 hPa rather than 200 hPa as the top level, I'm happy either way but 250 hPa might be better for mid-latitudes as 200 hPa could be a bit too high.

@jwarner8
Copy link
Contributor Author

jwarner8 commented Mar 3, 2025

Happy with the conf file, covers everything and works as expected. My only minor question is do we want 250 hPa rather than 200 hPa as the top level, I'm happy either way but 250 hPa might be better for mid-latitudes as 200 hPa could be a bit too high.

Thanks for reviewing, yep that's a fair comment and I think I've spent too much time in tropical thinking space! Agree for UK winter better with 250. Happy to change default to 250.

Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to merge once all CI tests complete.

@jwarner8 jwarner8 merged commit 170859a into main Mar 3, 2025
8 checks passed
@jwarner8 jwarner8 deleted the roseconf branch March 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants