Modify LFRic Apps files that call native/coordinate Jacobian files#184
Open
mo-rickywong wants to merge 8 commits intoMetOffice:mainfrom
Open
Modify LFRic Apps files that call native/coordinate Jacobian files#184mo-rickywong wants to merge 8 commits intoMetOffice:mainfrom
mo-rickywong wants to merge 8 commits intoMetOffice:mainfrom
Conversation
29 tasks
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @mo-lucy-gordon
In preparation to remove configuration variables from module scope, MetOffice/lfric_core#249 moves such practice in coordinate/native Jacobian routines to the kernel level. This PR is to modify calls to the updated Jacobian routines from kernels/unit-tests in LFRic_apps. Changes in this PR will be similar in nature, though touch a large number of files
This change doesn't change any KGOs and is an infrastructure change.
Linked PR
Code Quality Checklist
Testing
Test Suite Results - lfric_apps - AppsFloatJacobian/run9
Suite Information
Task Information
✅ succeeded tasks - 1106
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review