Checkpoint lfric_coupled

[stevemullerworth]

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

This branch incorporates changes from a Subversion branch referenced in Issue #233

It includes a small change to run an NRUN/CRUN test of the coupled model.

A few points to note:

1. It requires a linked lfric_core change (that Ed has created a branch for). However, Ed has made some improvements to that branch which are not reflected in this one.
2. The coupled NRUN/CRUN test does not work properly. A 1-day NRUN and 1-day CRUN appear to run, but the matching 2-day NRUN fails after the first day . Apparently, the suite is not creating correct the NEMO configuration files. Comments from others from a Teams chat are as follows:

"The variables that need to be set correctly are
nn_it000=1,
nn_itend=48
in the NEMO namelist.

Also I think ln_rstart should be set to true for the 2nd CRUN and false for the NRUN and first CRUN.
The drivers expect the environment variable CONTINUE to be set to true for a CRUN"

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable