Skip to content

Conversation

@yaswant
Copy link
Contributor

@yaswant yaswant commented Dec 11, 2025

Since this is a public repository, it makes sense to add some GitHub Copilot instructions for simulation-systems to guide contributors and Copilot.

@yaswant yaswant self-assigned this Dec 11, 2025
@t00sa t00sa removed their request for review January 6, 2026 07:55
Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yash, this is a sensible addition. I'm a bit concerned that there's too much that isn't specifically copilot here so I suggest we remove some of the sections and just reference the ideas in the general section.

requested
- Committing changes directly to `main` without review

## Documentation Structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required in this file

Sphinx/reStructuredText conventions.
- For technical documentation, include code blocks, examples, and
cross-references where appropriate.
- Use Copilot Chat to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these additional copilot points add anything more than what's in the General Guidelines above

- Suggest improvements to existing docs
- Answer questions about Sphinx directives and configuration

## Code of Conduct and Contribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need this section in this file. Maybe just mention the Contributing guidelines in the general section above

- Request code or documentation examples as needed.
- Ask for explanations of Sphinx or reStructuredText features if unsure.

## Coding Standards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above I'm not sure we need a coding standards section here (although we might need a coding standards section for this repo - maybe in the readme?)

Maybe we a line in the general guidelines along the lines of "All AI generated code is still expected to follow the projects coding guidelines".

@yaswant
Copy link
Contributor Author

yaswant commented Jan 7, 2026

@james-bruten-mo - I should have clarified that these instructions are there to guide GitHub Copilot's behaviour across the repository not for humans. It allows us to define specific rules, coding standards, and project context that Copilot automatically incorporates into its reasoning for every chat request and code review (currently being investigated by users in other area).

Copy link
Contributor

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying that Yash, happy for this to go on as is in that case

@james-bruten-mo james-bruten-mo merged commit 54d504a into MetOffice:main Jan 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants