-
Notifications
You must be signed in to change notification settings - Fork 14
Local deploy config #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local deploy config #530
Conversation
jennyhickson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tidy up and new feature. Just a suggestion on the readme for you.
README.md
Outdated
| uv run make clean deploy | ||
| ``` | ||
|
|
||
| Verify documentation (replace `<an.user>` and `<branch-name>` as required): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that make clean deploy works with uv, pip and conda, then please can we reorganise this readme to make that clearer? I'm thinking a section with the environment specific instructions and then a verify section with the firefox and deploy commands that are common to all options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Done.
jennyhickson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That looks good.
Add an option to deploy html documentation locally to users
~/public_html/simulation-systems/<branch-name>viamake clean deploycommand.Also take this opportunity to update
config.py