Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Dec 4, 2025

Similar implementation than KeyringClient but using the new unified keyring API (keyring v2) methods.


Note

Adds first-class support for the unified keyring v2 RPC surface across API, clients, and SDK.

  • New keyring-api v2 RPC: KeyringRpcV2Method, request/response structs (getAccount(s), createAccounts, deleteAccount, exportAccount, submitRequest), and isKeyringRpcV2Method
  • New keyring-snap-client KeyringClientV2 implementing v2 methods with strict response validation and export from v2/index
  • New keyring-internal-snap-client KeyringInternalSnapClientV2 using SnapControllerMessengerSender, supports withSnapId, and exports
  • New keyring-snap-sdk handleKeyringRequestV2 to validate/dispatch v2 JSON-RPC requests, throwing MethodNotSupportedError when appropriate
  • Extensive tests for v2 API, clients, and handler; minor fix: isKeyringRpcMethod is now a type guard and test message corrected

Written by Cursor Bugbot for commit f142721. This will update automatically on new commits. Configure here.

@ccharly ccharly marked this pull request as ready for review December 5, 2025 15:02
@ccharly ccharly requested a review from a team as a code owner December 5, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants