feat: add new hardware errors #421
Merged
+831
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ccharly
reviewed
Jan 12, 2026
ccharly
reviewed
Jan 13, 2026
Co-authored-by: Charly Chevalier <[email protected]>
ccharly
reviewed
Jan 13, 2026
ccharly
reviewed
Jan 14, 2026
ccharly
reviewed
Jan 14, 2026
ccharly
reviewed
Jan 14, 2026
Co-authored-by: Charly Chevalier <[email protected]>
ccharly
approved these changes
Jan 14, 2026
Comment on lines
+29
to
+32
| DeviceMultipleConnected = 3011, | ||
| DeviceMissingCapability = 3020, | ||
| DeviceBtcOnlyFirmware = 3021, | ||
| DeviceIncompatibleMode = 3030, |
Contributor
There was a problem hiding this comment.
The sub-sections seem wrong. But we can fix them up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new hardware errors and error codes to the @metamask/hw-device-sdk.
See: https://consensyssoftware.atlassian.net/browse/MUL-1304?atlOrigin=eyJpIjoiZmYwZmRmNDg1NDkzNDMxMjg2ZTBmNmUwYzQzZTA2ZjgiLCJwIjoiaiJ9
Examples
Note
Adds a structured hardware error system and Ledger code mappings to
hw-device-sdk.ErrorCode,Severity, andCategoryenums for consistent error typingHardwareWalletErrorwith unique IDs, user-friendly messages, metadata support,toJSON,toString,toDetailedString, and helpers (isCritical,isWarning,withMetadata)LEDGER_ERROR_MAPPINGSmapping Ledger status codes (e.g.,0x9000,0x6985,0x9840) to internalErrorCode/Severity/Categorywith optionaluserMessagesrc/index.ts; removes placeholder testCHANGELOG.mdWritten by Cursor Bugbot for commit 887c781. This will update automatically on new commits. Configure here.