Closed
Conversation
Contributor
|
This was fixed by #5123. I think your way might be a bit better, but the core bug should already be fixed. So up to you on whether you still want to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
It was not possible to use
yarn create-packageto create new package with the current implementation sincefs.statthrows an error if the path does not exists.Also, I replaced
statbyaccess, cause if the path already exists (no matter if it's a dir or file), the script will fail since the path is not "available".References
N/A
Changelog
N/A
Checklist