Merged
Conversation
DDDDDanica
force-pushed
the
release/278.0.0
branch
from
e81cb3d to
410d690
Compare
Gudahtt
reviewed
Jan 10, 2025
|
|
||
| ### Changed | ||
|
|
||
| - fix(3742): improve user segmentation with BigInt-based random generation ([#5110](https://github.com/MetaMask/core/pull/5110)) |
Member
There was a problem hiding this comment.
Could you remove the fix(3742) prefixes here? We don't use category prefixes, since we have headers instead. And it's a bit confusing to have this described as a fix given that it hasn't been categorized as such
Contributor
Author
There was a problem hiding this comment.
Yes definitely ! good catch ! removed in 810d7ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
Checklist