Skip to content

Comments

feat: validate nested transactions are not to internal accounts#5369

Merged
matthewwalsh0 merged 7 commits intomainfrom
feat/validate-transaction-batch-internal-account
Feb 26, 2025
Merged

feat: validate nested transactions are not to internal accounts#5369
matthewwalsh0 merged 7 commits intomainfrom
feat/validate-transaction-batch-internal-account

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 21, 2025

Explanation

Throw if addTransactionBatch is called with any nested transaction with a to matching an internal account.

Also fix @metamask/remote-feature-flag-controller dependency.

References

Changelog

See CHANGELOG.md.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 21, 2025 14:06
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners February 21, 2025 14:06
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "24.0.1-preview-30bb9023",
  "@metamask-previews/address-book-controller": "6.0.3-preview-30bb9023",
  "@metamask-previews/announcement-controller": "7.0.3-preview-30bb9023",
  "@metamask-previews/approval-controller": "7.1.3-preview-30bb9023",
  "@metamask-previews/assets-controllers": "51.0.1-preview-30bb9023",
  "@metamask-previews/base-controller": "8.0.0-preview-30bb9023",
  "@metamask-previews/bridge-controller": "1.0.0-preview-30bb9023",
  "@metamask-previews/bridge-status-controller": "1.0.0-preview-30bb9023",
  "@metamask-previews/build-utils": "3.0.3-preview-30bb9023",
  "@metamask-previews/composable-controller": "11.0.0-preview-30bb9023",
  "@metamask-previews/controller-utils": "11.5.0-preview-30bb9023",
  "@metamask-previews/earn-controller": "0.5.0-preview-30bb9023",
  "@metamask-previews/ens-controller": "15.0.2-preview-30bb9023",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-30bb9023",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-30bb9023",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-30bb9023",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-30bb9023",
  "@metamask-previews/keyring-controller": "19.2.1-preview-30bb9023",
  "@metamask-previews/logging-controller": "6.0.4-preview-30bb9023",
  "@metamask-previews/message-manager": "12.0.1-preview-30bb9023",
  "@metamask-previews/multichain": "2.2.0-preview-30bb9023",
  "@metamask-previews/multichain-network-controller": "0.1.2-preview-30bb9023",
  "@metamask-previews/multichain-transactions-controller": "0.5.0-preview-30bb9023",
  "@metamask-previews/name-controller": "8.0.3-preview-30bb9023",
  "@metamask-previews/network-controller": "22.2.1-preview-30bb9023",
  "@metamask-previews/notification-services-controller": "1.0.0-preview-30bb9023",
  "@metamask-previews/permission-controller": "11.0.6-preview-30bb9023",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-30bb9023",
  "@metamask-previews/phishing-controller": "12.3.2-preview-30bb9023",
  "@metamask-previews/polling-controller": "12.0.3-preview-30bb9023",
  "@metamask-previews/preferences-controller": "15.0.2-preview-30bb9023",
  "@metamask-previews/profile-sync-controller": "8.1.1-preview-30bb9023",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-30bb9023",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-30bb9023",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-30bb9023",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-30bb9023",
  "@metamask-previews/signature-controller": "23.2.1-preview-30bb9023",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-30bb9023",
  "@metamask-previews/transaction-controller": "46.0.0-preview-30bb9023",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-30bb9023"
}

@matthewwalsh0 matthewwalsh0 merged commit 1b35e86 into main Feb 26, 2025
136 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/validate-transaction-batch-internal-account branch February 26, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants